Skip to content

Commit

Permalink
[c++] Column abstraction: SOMAGeometryColumn, part 3 (#3427)
Browse files Browse the repository at this point in the history
* Add concrete class wrapper for TileDB attribute

* Replace string_view with string when returning column name, add current domain checks, replace vector with span when selecting points

* Add helper methods for to and from arrow contructs

* SOMAColumn abstract class definition

* Remove fmt::format

* Remove unneeded methods and member variables

* Add concrete class wrapper for TileDB dimension

* Replace string_view with string when returning column name, add current domain checks, replace vector with span when selecting points

* Fix unit test

* Remove duplicate declaration

* Add concrete class wrapper for indexable geometry column

* Add minimal testing for dimensions

* Misc fixes

* Add read test case

* Add missing `override`

* Remove current_domain flag

* Do not export soma column [skip ci]

* Replace string_view with string when returning column name, add current domain checks, replace vector with span when selecting points

* lint fixes

* Address review comments

* Add description and license

* Fix unit test cases

* Remove virtual inheritance

* Comply with C.128

* Rename `dom` and `domain` variables
  • Loading branch information
XanthosXanthopoulos authored Jan 8, 2025
1 parent eabdb30 commit 824f648
Show file tree
Hide file tree
Showing 6 changed files with 605 additions and 15 deletions.
2 changes: 2 additions & 0 deletions libtiledbsoma/src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ add_library(TILEDB_SOMA_OBJECTS OBJECT
${CMAKE_CURRENT_SOURCE_DIR}/soma/soma_column.cc
${CMAKE_CURRENT_SOURCE_DIR}/soma/soma_attribute.cc
${CMAKE_CURRENT_SOURCE_DIR}/soma/soma_dimension.cc
${CMAKE_CURRENT_SOURCE_DIR}/soma/soma_geometry_column.cc
${CMAKE_CURRENT_SOURCE_DIR}/soma/soma_collection.cc
${CMAKE_CURRENT_SOURCE_DIR}/soma/soma_experiment.cc
${CMAKE_CURRENT_SOURCE_DIR}/soma/soma_measurement.cc
Expand Down Expand Up @@ -205,6 +206,7 @@ install(FILES
${CMAKE_CURRENT_SOURCE_DIR}/soma/soma_column.h
${CMAKE_CURRENT_SOURCE_DIR}/soma/soma_attribute.h
${CMAKE_CURRENT_SOURCE_DIR}/soma/soma_dimension.h
${CMAKE_CURRENT_SOURCE_DIR}/soma/soma_geometry_column.h
${CMAKE_CURRENT_SOURCE_DIR}/soma/soma_collection.h
${CMAKE_CURRENT_SOURCE_DIR}/soma/soma_dataframe.h
${CMAKE_CURRENT_SOURCE_DIR}/soma/soma_dense_ndarray.h
Expand Down
Loading

0 comments on commit 824f648

Please sign in to comment.