-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Experiment-level upgrader/resizer #3157
Conversation
Co-authored-by: nguyenv <[email protected]>
70c3c3a
to
fff5c72
Compare
4b9f4f4
to
dcecc32
Compare
@nguyenv I decided not to go with |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3157 +/- ##
==========================================
+ Coverage 83.01% 83.30% +0.29%
==========================================
Files 50 51 +1
Lines 5247 5458 +211
==========================================
+ Hits 4356 4547 +191
- Misses 891 911 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; Internally, there isn't much difference between using attrs
vs TypedDict
, so it is fine keeping it as is. I do think attrs
does give us additional advantages like providing more enhanced type checking and default value generators which could simplify the code here but not substantial that it warrants changing.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Tests the experiment-level upgrader and resizer.
Notes for Reviewer:
There is more to do in
tiledbsoma.io
for append-mode ingest on #3148.Example verbose output: