-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Append mode with resizing #3148
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3148 +/- ##
==========================================
+ Coverage 83.18% 83.29% +0.10%
==========================================
Files 51 51
Lines 5483 5495 +12
==========================================
+ Hits 4561 4577 +16
+ Misses 922 918 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b41fe2e
to
f36d616
Compare
73934a7
to
8938131
Compare
5659d42
to
71929ba
Compare
6f1fe0e
to
57b7263
Compare
f269ee9
to
adb5dc7
Compare
d4cd94e
to
bf17979
Compare
bf17979
to
015b195
Compare
015b195
to
2dd2887
Compare
70c3c3a
to
fff5c72
Compare
2dd2887
to
b53f9e6
Compare
08ac2d7
to
8d2a773
Compare
a122eac
to
1c3b958
Compare
1c3b958
to
251542b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, but I'm not super familiar with the ingestor code so you may want to want to wait for @nguyenv to review as well.
One question: Is that resize code required before ingesting with the new shape feature? If so, what error does the user get if they fail to resize first?
@jp-dark they get a message like this:
which we can perhaps catch and rethrow with a friendlier error message ... |
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Support experipment-level
upgrade_shape
andresize
.Notes for Reviewer: