Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r/ci] Controlled downgrade for TileDB-R 0.25 #2373

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Apr 3, 2024

Issue and/or context: Applies the same pattern on the release-1.9 branch as #1972 did for the release-1.5 branch, #1996 did for the release-1.6 branch, #2157 did for the release-1.7 branch, and #2295 did for the release-1.8 branch.

Standard procedure:
https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases#incrementing-core-versions

Changes: As on #1972, #1996, #2157, and #2295. This is necessary since TileDB-R 0.26.0 will soon exist, and the R language's DESCRIPTION file does not syntactically support tiledb < 0.26 or tiledb <= 0.26. Therefore (see also this comment #1996 (comment)) we do a controlled downgrade to TileDB-R 0.25 on this PR, for the release-1.9 branch.

Notes for Reviewer: Every stanza in this PR has been proved necessary via the dialog on #1972, #1996, #2157, and #2295. See in particular #1996 (review).

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #2373 (afdc498) into release-1.9 (2a143aa) will decrease coverage by 14.97%.
Report is 1 commits behind head on release-1.9.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.9    #2373       +/-   ##
================================================
- Coverage        81.10%   66.14%   -14.97%     
================================================
  Files               89      143       +54     
  Lines             8337    12807     +4470     
  Branches             0      511      +511     
================================================
+ Hits              6762     8471     +1709     
- Misses            1575     4235     +2660     
- Partials             0      101      +101     
Flag Coverage Δ
libtiledbsoma 38.71% <ø> (?)
python 90.59% <ø> (ø)
r 71.90% <ø> (-0.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.59% <ø> (ø)
libtiledbsoma 19.70% <ø> (∅)

@eddelbuettel
Copy link
Contributor

eddelbuettel commented Apr 3, 2024

and the R DESCRIPTION file does not syntactically support tiledb < 0.26 or tiledb <= 0.26.

For completeness, I learned this week (following discussions with a friend) that it does.

And indeed I built the SOMA package here with

    tiledb (>= 0.25.0), tiledb (<= 0.26.0),

(where the second value should probably have been 0.25.98 or similar given the <=). Earlier R told me when I tried an = (against the then-version on my box)

 Malformed Depends or Suggests or Imports or Enhances field.
Entries with infeasible comparison operator:
  tiledb (= 0.25.0.6)
Only operators '<=' and '>=' are possible.

I have not had time to work through ramifications or do any tests. I have an inkling that this may not work unless we do what we hitherto avoided namely providing repos with the aimed-for version (which has been suggested a few times).

(PS Of course, I cannot find any reference to it in Writing R Extensions. Sigh. Maybe R Internals or R Admin. The code example was real. I let me have a pair less-than-or-equal and greater-than-or-equal. Things you learn after 25 years.)

@johnkerl johnkerl merged commit 7da4497 into release-1.9 Apr 3, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/controlled-downgrade-1.9 branch April 3, 2024 21:18
@johnkerl
Copy link
Member Author

johnkerl commented Apr 3, 2024

More discussion on #2374 about possible new experiments, beyond the known-good pattern on this PR which is proven to keep our CI green for four releases now.

@johnkerl
Copy link
Member Author

johnkerl commented Apr 5, 2024

[sc-44675]

Copy link

This pull request has been linked to Shortcut Story #44675: tiledbsoma 1.9.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants