-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r/ci] Controlled downgrade for TileDB-R 0.25 #2373
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.9 #2373 +/- ##
================================================
- Coverage 81.10% 66.14% -14.97%
================================================
Files 89 143 +54
Lines 8337 12807 +4470
Branches 0 511 +511
================================================
+ Hits 6762 8471 +1709
- Misses 1575 4235 +2660
- Partials 0 101 +101
Flags with carried forward coverage won't be shown. Click here to find out more.
|
For completeness, I learned this week (following discussions with a friend) that it does. And indeed I built the SOMA package here with
(where the second value should probably have been 0.25.98 or similar given the
I have not had time to work through ramifications or do any tests. I have an inkling that this may not work unless we do what we hitherto avoided namely providing repos with the aimed-for version (which has been suggested a few times). (PS Of course, I cannot find any reference to it in Writing R Extensions. Sigh. Maybe R Internals or R Admin. The code example was real. I let me have a pair less-than-or-equal and greater-than-or-equal. Things you learn after 25 years.) |
More discussion on #2374 about possible new experiments, beyond the known-good pattern on this PR which is proven to keep our CI green for four releases now. |
[sc-44675] |
This pull request has been linked to Shortcut Story #44675: tiledbsoma 1.9.4. |
Issue and/or context: Applies the same pattern on the
release-1.9
branch as #1972 did for therelease-1.5
branch, #1996 did for therelease-1.6
branch, #2157 did for therelease-1.7
branch, and #2295 did for therelease-1.8
branch.Standard procedure:
https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases#incrementing-core-versions
Changes: As on #1972, #1996, #2157, and #2295. This is necessary since TileDB-R 0.26.0 will soon exist, and the R language's
DESCRIPTION
file does not syntactically supporttiledb < 0.26
ortiledb <= 0.26
. Therefore (see also this comment #1996 (comment)) we do a controlled downgrade to TileDB-R 0.25 on this PR, for therelease-1.9
branch.Notes for Reviewer: Every stanza in this PR has been proved necessary via the dialog on #1972, #1996, #2157, and #2295. See in particular #1996 (review).