-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r/ci] Controlled downgrade for TileDB-R 0.23 #2157
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.7 #2157 +/- ##
===============================================
- Coverage 78.53% 71.99% -6.55%
===============================================
Files 136 101 -35
Lines 10804 7002 -3802
Branches 209 209
===============================================
- Hits 8485 5041 -3444
+ Misses 2219 1861 -358
Partials 100 100
Flags with carried forward coverage won't be shown. Click here to find out more.
|
74a1dce
to
8c43347
Compare
8c43347
to
abc68b8
Compare
One difference is that because we do not have a CRAN release we also have no corresponding r2u or macOS binaries. We may still want to impose the r-universe versions regardless. |
@eddelbuettel This PR is not ready for review. Please do not review this PR. I'll mark this PR as ready for review once its CI is complete, and once I've answered all questions I need to have CI answer for me. |
@johnkerl I tried to explain how this current 0.24.0 is not like the previous ones. |
@eddelbuettel thank you! |
https://github.com/single-cell-data/TileDB-SOMA/actions/runs/7981104186/job/21792145630?pr=2157 shows that we are getting core 2.19.0 from TileDB-Py 0.26.0 but core 2.19.1 from TileDB-R 0.24.0:
cc @ihnorton |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a bit of a baked-in bias for 'newer/higher is better' but if it is felt that 2.19.0 everywhere is better / more feasible then this seems to do it so ...
@eddelbuettel same:) |
Issue and/or context: Applies the same pattern as #1972 did for the
release-1.5
branch and #1996 did for therelease-1.6
branch.Changes: As on #1972 and #1996. This is necessary since TileDB-R 0.24.0 now exists, and the R
DESCRIPTION
file does not syntactically supporttiledb < 0.24
ortiledb <= 0.24
. Therefore (see also this comment #1996 (comment)) we do a controlled downgrade to TileDB-R 0.23 on this PR, for therelease-1.7
branch.Notes for Reviewer:
Every stanza in this PR has been proved necessary via the dialog on #1972 and #1996. See in particular #1996 (review).