Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neaten logger-init code #196

Merged
merged 1 commit into from
Jun 25, 2022
Merged

Neaten logger-init code #196

merged 1 commit into from
Jun 25, 2022

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Jun 25, 2022 •
edited
Loading

Following great advice from @gsakkis

To check:

  • tools/outgestor
  • tools/outgestor -q
  • Make sure the first one prints progress updates and the latter does not

aaronwolen
aaronwolen approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@johnkerl johnkerl merged commit 52e7897 into main Jun 25, 2022
@johnkerl johnkerl deleted the kerl/logger-neaten branch June 25, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronwolen aaronwolen aaronwolen approved these changes

@gsakkis gsakkis Awaiting requested review from gsakkis

@bkmartinjr bkmartinjr Awaiting requested review from bkmartinjr

@Shelnutt2 Shelnutt2 Awaiting requested review from Shelnutt2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnkerl @aaronwolen