Code

TDL-15198: Added best practices#116

Code

Merged

dbshah1212 merged 14 commits intomastersinger-io/tap-shopify:masterfrom best-practicessinger-io/tap-shopify:best-practicesCopy head branch name to clipboardSep 30, 2021

+20-16

Commits

Commits on Aug 9, 2021

• added best practices

  

  harshpatel4_crest

  committed
  fcfaf21

  Copy full SHA for fcfaf21

• resolved pylint

  

  harshpatel4_crest

  committed
  fc909d8

  Copy full SHA for fc909d8

• test: run only pagination test

  

  harshpatel4_crest

  committed
  498c620

  Copy full SHA for 498c620

• test: run only pagination test

  

  harshpatel4_crest

  committed
  d196597

  Copy full SHA for d196597

Commits on Aug 10, 2021

• test: run all tests

  

  harshpatel4_crest

  committed
  ca11e98

  Copy full SHA for ca11e98

• test: run all tests

  

  harshpatel4_crest

  committed
  6b59b64

  Copy full SHA for 6b59b64

• test: run only paginaiton test

  

  harshpatel4_crest

  committed
  c9808a8

  Copy full SHA for c9808a8

• test: updated variable page size setting

  

  harshpatel4_crest

  committed
  4a44518

  Copy full SHA for 4a44518

• run all the tests

  

  harshpatel4_crest

  committed
  34239ba

  Copy full SHA for 34239ba

Commits on Aug 27, 2021

• made changes according to comments

  

  harshpatel4_crest

  committed
  4bbe151

  Copy full SHA for 4bbe151

Commits on Sep 7, 2021

• Added integration test for start date and bookmark both are provided

  savan-chovatiya

  committed
  aedbea8

  Copy full SHA for aedbea8

Commits on Sep 10, 2021

• Removed startdate&bookmark test as it's implicitly covered in bookmark test

  savan-chovatiya

  committed
  d626909

  Copy full SHA for d626909

Commits on Sep 13, 2021

• Merge branch 'master' into best-practices

  hpatel41

  authored
  4d58f68

  Copy full SHA for 4d58f68

Commits on Sep 29, 2021

• Merge branch 'master' into best-practices

  KrisPersonal

  authored
  922d536

  Copy full SHA for 922d536