TDL-15198: Added best practices #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 9, 2021 20:49
hpatel41
requested review from
dbshah1212,
karanpanchal-crest and
savan-chovatiya
dbshah1212
reviewed
Aug 26, 2021
tap_shopify/streams/base.py
Outdated
| @@ -127,7 +131,7 @@ def get_objects(self): | |||
|
|
|||
| stop_time = singer.utils.now().replace(microsecond=0) | |||
| date_window_size = float(Context.config.get("date_window_size", DATE_WINDOW_SIZE)) | |||
| results_per_page = Context.get_results_per_page(RESULTS_PER_PAGE) | |||
| # results_per_page = Context.get_results_per_page(RESULTS_PER_PAGE) | |||
There was a problem hiding this comment.
Why we added this commented code?
There was a problem hiding this comment.
Done, removed the line
dbshah1212
reviewed
Aug 26, 2021
tests/test_pagination.py
Outdated
| self.API_LIMIT, | ||
| self.get_properties().get('result_per_page', self.DEFAULT_RESULTS_PER_PAGE) | ||
| ) | ||
| # minimum_record_count = stream_metadata.get( |
There was a problem hiding this comment.
Can we remove this commented code if not required?
There was a problem hiding this comment.
Removed the commented code
dbshah1212
approved these changes
Aug 31, 2021
KrisPersonal
approved these changes
Sep 29, 2021
tmck-code
pushed a commit
to lexerdev/tap-shopify
that referenced
this pull request
Feb 3, 2022
* added best practices * resolved pylint * test: run only pagination test * test: run only pagination test * test: run all tests * test: run all tests * test: run only paginaiton test * test: updated variable page size setting * run all the tests * made changes according to comments * Added integration test for start date and bookmark both are provided * Removed startdate&bookmark test as it's implicitly covered in bookmark test Co-authored-by: savan-chovatiya <[email protected]> Co-authored-by: KrisPersonal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added best practices
QA steps
Risks
Rollback steps