Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing unread badge #908

Merged
merged 4 commits into from
May 30, 2019
Merged

Fix missing unread badge #908

merged 4 commits into from
May 30, 2019

Conversation

pkuczynski
Copy link
Contributor

@pkuczynski pkuczynski commented May 25, 2019 •
edited by sindresorhus
Loading

Fixes #893
Fixes #905

@pkuczynski
Copy link
Contributor Author

There is also a reference to ._7t0d in browser.css and I am not sure if this should be updated? It's marked as Hide profile picture, which I am not sure why anybody would like to have enabled?

@pkuczynski pkuczynski mentioned this pull request May 25, 2019
Closed
@sindresorhus
Copy link
Owner

There is also a reference to ._7t0d in browser.css and I am not sure if this should be updated? It's marked as Hide profile picture, which I am not sure why anybody would like to have enabled?

That's unrelated to this.

sindresorhus
sindresorhus reviewed May 26, 2019
View reviewed changes
source/browser.ts Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

I tried out this PR now, but I'm not getting any unread badge for new messages on macOS.

@pkuczynski
Copy link
Contributor Author

pkuczynski commented May 27, 2019 •
edited
Loading

I do. So maybe it's just a matter of different version being served for my account (A/B testing). The only thing I changed from the previous implementation is selectors - in particular, https://github.com/sindresorhus/caprine/pull/908/files#diff-2c24973e0432bc28df516c6328533f5dR424

Can you check what would be the selector for the div wrapping the profile picture for you?

Screenshot 2019-05-27 at 18 09 40

@pkuczynski
Copy link
Contributor Author

I think I found another issue with group chats. Working on this... Stay tuned.

@pkuczynski
Copy link
Contributor Author

@sindresorhus I have an improved fix, which:

  • moves all conversation list logic run in browser into a separate file
  • parse conversation list more based on aria or data attributes, and less on styles, so it should be much more error resistant
  • introduce error handling for loading conversation icons (lack of this was causing missing badge icon)
  • adds some sane fallbacks for the future when the new messenger is released with changed structure

Looking forward for your feedback and getting this released soon. I have no new message notification in a current version which drives me nuts :)

@pkuczynski pkuczynski changed the title Fix no longer getting unread badge Fix missing unread badge May 29, 2019
@pkuczynski
Copy link
Contributor Author

@sindresorhus did you maybe had a chance to look into this? Apologies for being annoying, but you would not imagine how much it drives me nuts to not know when someone sent me a message and having to switch to Caprine all the time... :/

@reganlawton reganlawton mentioned this pull request May 30, 2019
Closed
@sindresorhus sindresorhus merged commit 16d9e3b into sindresorhus:master May 30, 2019
@sindresorhus
Copy link
Owner

Thank you for fixing this! 🙌

It's been driving me crazy too.

@pkuczynski pkuczynski deleted the fix-badge-icon branch May 30, 2019 21:00
@pkuczynski
Copy link
Contributor Author

Your welcome. Thanks for the great job you did so far! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not getting notified after latest update No longer getting unread badge
2 participants
@pkuczynski @sindresorhus