-
-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop notifications, and Messenger Settings don't show #911
Comments
Confirm that is the case on Mac OS 10.14.5 as well |
same with the message requests, archived threads, etc. |
I have a change to restore settings and read badge, code was commented out in the last version but the notifications still aren't triggering 🤔 |
Confirmed as well on macOS 10.14.4. |
confirmed on macOS 10.14.2 |
…g due to invalid selector.
Settings menu should be resolved in my PR #916 my testing found that it was due to a messing selector. My desktop notifications issue was due to them being disabled, as I was in do not disturb mode 🤦♂ |
Notifications were fixed in #893. |
@sindresorhus Im taking that was the Version 2.31.1 release? Either way they were working for me in 2.31.1, once I disabled DND mode. The PR I submitted is just a selector change to fix menu. |
The Settings menu is already working with the new design. |
@sindresorhus I have the update to support both. |
I'm not interested in supporting both. Most users are on the new design now. |
Are they? 🙂 I'm still on the old design, so are some people from my contacts list I've asked. Facebook is taking a multi-month rollout approach on this one. 😛 |
the problems still exist on |
@jonyroda97 it’ll continue regardless of the version it’s not a app issues, Facebook are rolling out different version of HTML with different selectors so the new selector trigger doesn’t work for people that Facebook hasn’t rollouts the new design out too yet, which seems to be quite a few people. It most likely a region based rollout so hopefully everyone should be switched over in the next week or so. |
So wait, let me get this straight. |
More or less but notifications were fixed in #893 so mentioned above. |
Good news. So, how should I know that FB finally updated messenger in my region? What are the symptoms, and whatnot? Notifications should start showing? |
@Skivster Here's a side-by-side comparison of both old and new design: commit 15fc43b |
:O Thanks for the screens ;) |
Can confirm, new update fixed a lot of bugs. ctrl+ , notifications, forwarding messages and everything else. |
I'm sorry to comment on this old issue, but I'm not able to open settings at all. Version 2.4.1. |
Like in the title, desktop notifications, and Messenger Settings don't show, and there is no way to make them working.
Can't find a setting to turn on/off notifications.
Shortcut
ctrl + ,
doesn't do anything, nor clicking "Messenger Settings" in the dropdown menu.Caprine 2.31.1
Windows 7 x64.. Dont know what more should I post here..
The text was updated successfully, but these errors were encountered: