Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop notifications, and Messenger Settings don't show #911

Closed
Skivster opened this issue May 27, 2019 · 21 comments
Closed

Desktop notifications, and Messenger Settings don't show #911

Skivster opened this issue May 27, 2019 · 21 comments

Comments

@Skivster
Copy link

Like in the title, desktop notifications, and Messenger Settings don't show, and there is no way to make them working.
Can't find a setting to turn on/off notifications.
Shortcut ctrl + , doesn't do anything, nor clicking "Messenger Settings" in the dropdown menu.
Caprine 2.31.1
Windows 7 x64.. Dont know what more should I post here..

@reganlawton
Copy link
Contributor

Confirm that is the case on Mac OS 10.14.5 as well

@jonyroda97
Copy link

same with the message requests, archived threads, etc.

@reganlawton
Copy link
Contributor

I have a change to restore settings and read badge, code was commented out in the last version but the notifications still aren't triggering 🤔

@eexit
Copy link

eexit commented May 28, 2019

Confirmed as well on macOS 10.14.4.

@minhkhuong2404
Copy link

confirmed on macOS 10.14.2

reganlawton added a commit to reganlawton/caprine that referenced this issue May 30, 2019
@reganlawton
Copy link
Contributor

Settings menu should be resolved in my PR #916 my testing found that it was due to a messing selector. My desktop notifications issue was due to them being disabled, as I was in do not disturb mode 🤦‍♂

@sindresorhus
Copy link
Owner

Notifications were fixed in #893.

@reganlawton
Copy link
Contributor

@sindresorhus Im taking that was the Version 2.31.1 release? Either way they were working for me in 2.31.1, once I disabled DND mode. The PR I submitted is just a selector change to fix menu.

@sindresorhus
Copy link
Owner

The PR I submitted is just a selector change to fix menu.

The Settings menu is already working with the new design.

@reganlawton
Copy link
Contributor

@sindresorhus I have the update to support both.

@sindresorhus
Copy link
Owner

I'm not interested in supporting both. Most users are on the new design now.

@CvX
Copy link
Collaborator

CvX commented May 30, 2019

Most users are on the new design now.

Are they? 🙂 I'm still on the old design, so are some people from my contacts list I've asked. Facebook is taking a multi-month rollout approach on this one. 😛

@jonyroda97
Copy link

the problems still exist on v2.31.2

@reganlawton
Copy link
Contributor

@jonyroda97 it’ll continue regardless of the version it’s not a app issues, Facebook are rolling out different version of HTML with different selectors so the new selector trigger doesn’t work for people that Facebook hasn’t rollouts the new design out too yet, which seems to be quite a few people.

It most likely a region based rollout so hopefully everyone should be switched over in the next week or so.

@Skivster
Copy link
Author

Skivster commented May 30, 2019

So wait, let me get this straight. Messenger settings not showing, nor desktop notifications, are because of the HTML/UI changes that are not yet rolled out in my region?

@reganlawton
Copy link
Contributor

More or less but notifications were fixed in #893 so mentioned above.

@Skivster
Copy link
Author

Good news. So, how should I know that FB finally updated messenger in my region? What are the symptoms, and whatnot? Notifications should start showing?
Im simply curious :)

@CvX
Copy link
Collaborator

CvX commented May 30, 2019

@Skivster Here's a side-by-side comparison of both old and new design: commit 15fc43b

@Skivster
Copy link
Author

:O Thanks for the screens ;)
So, Full Colour "phone" icons, Bold Icons on the left, and User Name moved to the left. Thanks, I'll watch when it changes, and I'll make an update when time comes. Thanks!

@Skivster
Copy link
Author

Can confirm, new update fixed a lot of bugs. ctrl+ , notifications, forwarding messages and everything else.
Also, the notifications are better looking and working than in Messenger for Desktop. Thank you all for your hard work :)

@erikstorli
Copy link

I'm sorry to comment on this old issue, but I'm not able to open settings at all. Version 2.4.1.
It works with my work iMac (late 2015) 10.15.1, but not with a brand new MacBook Pro 16-inch 10.15.1. Any suggestions on how to debug this? Tried the menu and shortcut. No go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants