Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on quit caused by Electron race issue #811

Merged
merged 2 commits into from
Apr 17, 2019

Conversation

whitecrownclown
Copy link
Contributor

@whitecrownclown whitecrownclown commented Mar 5, 2019

Fixes #809

@sindresorhus
Copy link
Owner

@whitecrownclown Are you able to reproduce the issue?

@sindresorhus
Copy link
Owner

The issue makes no sense as the windows are not supposed to be quit until after the before-quit event is called:

Emitted before the application starts closing its windows. Calling event.preventDefault() will prevent the default behaviour, which is terminating the application.
- https://electronjs.org/docs/api/app#event-before-quit

@whitecrownclown
Copy link
Contributor Author

whitecrownclown commented Mar 13, 2019

@sindresorhus No, I couldn't reproduce this issue and I agree, it doesn't make any sense. I thought there may be an electron issue which could cause it but I couldn't find anything related.

Edit: The PR obviously isn't a "real" fix, at least from what we can tell from the electron docs, I'm ok with either merging or closing it. Thanks!

@sindresorhus sindresorhus changed the title Attempt to fix on quit error Fix error on quit caused by Electron race issue Apr 17, 2019
@sindresorhus sindresorhus merged commit 0b955cb into sindresorhus:master Apr 17, 2019
@sindresorhus
Copy link
Owner

Merging this as more people are experiencing the issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on quit
2 participants