Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on quit #809

Closed
adrienhuchet opened this issue Mar 5, 2019 · 6 comments · Fixed by #811
Closed

Error on quit #809

adrienhuchet opened this issue Mar 5, 2019 · 6 comments · Fixed by #811

Comments

@adrienhuchet
Copy link

capture d ecran 2019-03-05 a 16 00 11

when I minimize the app and right click on the icon and click on quit this error show up
@whitecrownclown
Copy link
Contributor

@adrienhuchet What version of Caprine are you using? I don't see it happening on v2.30

@adrienhuchet
Copy link
Author

capture d ecran 2019-03-05 a 21 51 12

I use v2.30

@whitecrownclown whitecrownclown mentioned this issue Mar 5, 2019
Merged
@sindresorhus
Copy link
Owner

@adrienhuchet Does it happen every time? I tried reproducing it with the same Caprine version and I'm not seeing the error.

@adrienhuchet
Copy link
Author

No, it does not happen every time. I have not had the error lately !

@zoonderkins
Copy link

I have this issue sometimes bad internet or sleep and wake up Mbpr will cause this problem

sindresorhus added a commit that referenced this issue Apr 17, 2019
@whitecrownclown @sindresorhus
Fix error on quit caused by Electron race issue (#811)
0b955cb 
Fixes #809

Co-authored-by: Sindre Sorhus <[email protected]>
@sindresorhus
Copy link
Owner

If someone can reliably reproduce this, please open an issue on https://github.com/electron/electron

@sindresorhus sindresorhus mentioned this issue Apr 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error on quit caused by Electron race issue whitecrownclown/caprine
4 participants
@sindresorhus @zoonderkins @whitecrownclown @adrienhuchet