Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style improvements #757

Merged
merged 18 commits into from
Feb 4, 2019
Merged

Style improvements #757

merged 18 commits into from
Feb 4, 2019

Conversation

CvX
Copy link
Collaborator

@CvX CvX commented Feb 3, 2019

Style improvements

Fix the “forward message” icon in dark mode

forward-before forward-after

Fix message composer icons in light full-vibrancy

composer-light-before composer-light-after
composer-dark-before composer-dark-after

Improve contrast on contact name links

dark-link-color1-before dark-link-color1-after
dark-link-color2-before dark-link-color2-after

Fix “search in conversation” in dark mode

dark-search-before dark-search-after

Improve the text color in “Delete message” popup

dark-delete-popup-before dark-delete-popup-after

Improve “Message Reactions” popup in dark mode

reactions-popup-dark-before reactions-popup-dark-after

Tweak deleted messages

Improve code blocks

Tweak link previews

message-light-no-vibrancy-before message-light-no-vibrancy-after
message-light-side-vibrancy-before message-light-side-vibrancy-after
message-light-full-vibrancy-before message-light-full-vibrancy-after
message-dark-no-vibrancy-before message-dark-no-vibrancy-after
message-dark-side-vibrancy-before message-dark-side-vibrancy-after
message-dark-full-vibrancy-before message-dark-full-vibrancy-after

Tweak attached files

attachments-light-full-vibrancy-before attachments-light-full-vibrancy-after
attachments-dark-side-vibrancy-before attachments-dark-side-vibrancy-after
attachments-dark-full-vibrancy-before attachments-dark-full-vibrancy-after

Tweak chat bot menu

bot-menu-before bot-menu-after

@sindresorhus
Copy link
Owner

Wow. Lots of good improvements here. By the way, you don't have to screenshot every change. I trust you've done the right thing :)

@sindresorhus sindresorhus merged commit 93d0a1b into sindresorhus:master Feb 4, 2019
@CvX
Copy link
Collaborator Author

CvX commented Feb 4, 2019

By the way, you don't have to screenshot every change. I trust you've done the right thing :)

I don't trust myself, lol. 😜
I find these screenshots useful for both double-checking my own work, and for confirming regressions in the future. 🙂

@hroland
Copy link

hroland commented Feb 12, 2019

God bless you @CvX 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants