Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #173 #174

Merged
merged 10 commits into from
Mar 23, 2017
Merged

Fix #173 #174

merged 10 commits into from
Mar 23, 2017

Conversation

dudeofawesome
Copy link
Contributor

Facebook updated Messenger to add a white border around messages. This makes that border transparent in dark mode.

It also fixes a rendering issue with the header image in the readme

@dudeofawesome
Copy link
Contributor Author

I'm not sure why it's trying to merge in those old commits from my last PR. They don't show up in the diff though.

@sindresorhus sindresorhus changed the title Fixing issue #173 Fix #173 Mar 23, 2017
@sindresorhus sindresorhus merged commit 67f2353 into sindresorhus:master Mar 23, 2017
@sindresorhus
Copy link
Owner

Thanks :)

CvX added a commit to CvX/caprine that referenced this pull request Feb 3, 2019
This reverts commit 67f2353.

This CSS rule is no longer needed.
sindresorhus pushed a commit that referenced this pull request Feb 4, 2019
* Replace colors with existing CSS variables

* Extract code-blocks CSS to a separate file

* Fix the “forward message” icon in dark mode

* Fix message composer icons in light full-vibrancy

* Revert "Fix #173 (#174)"

This reverts commit 67f2353.

This CSS rule is no longer needed.

* Remove unused CSS rules

* Improve contrast on contact name links

* Revert “Vertically align “conversation info” buttons.”

Messenger fixed this on their side. Our fix has now the opposite effect.

* Remove an overreaching CSS rule

* Fix “search in conversation” in dark mode

* Improve the text color in “Delete message” popup

* Improve “Message Reactions” popup in dark mode

* Improve code blocks

* Tweak deleted messages

* Tweak link previews

* Tweak attached files

* Tweak chat bot menu

* Fix variation in brightness of message composer icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants