Fix archive conversation issues #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a chat is archived the selection is switched to the next one. Also added some fixes using `elementReady()` since some elements are requested before page is loaded.
Also fixed leaving group conversations issue.
CvX
requested changes
Jan 18, 2019
Non-async functions that call async functions are now turned to async.
Fixed that check for chat type via chat options menu. Also explained the process in the comment.
Reverting to use of elementReady for getting element.
|
@CvX here are updates. This should be it. |
|
I like the idea of making the |
showSettingsMenu is used in a cuple of places and in one place it needs to wait for element to be created to show the menu. In that place so far we've been using a custom function elementReady instead of document.querySelector. Now showSettingsMenu is made async so it can now use elementReady.
|
Here it is 😃 |
Here's a work around. It's ugly, it's not foolproof but it works.
Merged the branch with CvX's arvhice-fix branch that contains new mechanism for querying menus and clicking on menu items. Also used that new mechanism for openArchiveModal function. Great work by @CvX.
Since that’s what this function does. There’s no modal.
That argument is 1-based, it later gets converted to a 0-based index.
Prevents errors in situations where conversation list is replaced with another view.
|
I've cleaned up the code a little bit. Please take a look, I want to be sure everything is as expected. 😉 |
|
Looks good 👌🏻. I've just tested it and found out that actually delete chat option behaves just like archive option used to, gets removed from the list and leaves the chat panel empty. Should we add the same feature (open next conversation) to delete chat option while were here? |
|
Oh, yeah. 😅That would be great! 😃 |
Function `openDeleteModal` was renamed to `deleteSelectedConverastion` and is now after delete selecting next conversation so chat panel wont be empty.
CvX
approved these changes
Jan 19, 2019
sindresorhus
pushed a commit
that referenced
this pull request
Jan 20, 2019
Co-authored-by: Jarek Radosz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed archive conversation issues. Now when a conversation is archived, it automatically switches to the next conversation so there wont be an empty display. Also with this PR fixed the issue with archiving group conversations.
Closes: #590
Closes: #591