Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archiving group messages tries to leave the group convo instead of archiving it #590

Closed
jonleung opened this issue Sep 20, 2018 · 3 comments · Fixed by #732
Closed

Archiving group messages tries to leave the group convo instead of archiving it #590

jonleung opened this issue Sep 20, 2018 · 3 comments · Fixed by #732
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@jonleung
Copy link

jonleung commented Sep 20, 2018 •
edited by issuehunt-oss bot
Loading

Issuehunt badges

OSX 10.12.6

Instructions to reproduce:

  1. Click any group conversation in the sidebar
  2. Cmd + Shift + a
  3. I get this message:

image

Archiving messages is the primary reason I have downloaded this app. SO EXCITED TO HAVE THIS WORKING! Thank you for creating this!

dusansimic earned $30.00 by resolving this issue!
@IssueHuntBot
Copy link

@issuehuntfest has funded $30.00 to this issue. See it on IssueHunt

dusansimic added a commit to dusansimic/caprine that referenced this issue Jan 18, 2019
@dusansimic
Fixed sindresorhus#590
d41973a 
Also fixed leaving group conversations issue.
@dusansimic dusansimic mentioned this issue Jan 18, 2019
Merged
@IssueHuntBot
Copy link

@dusansimic has submitted a pull request. See it on IssueHunt

@IssueHuntBot
Copy link

@sindresorhus has rewarded $27.00 to @dusansimic. See it on IssueHunt

  • 💰 Total deposit: $30.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $3.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix archive conversation issues dusansimic/caprine
3 participants
@sindresorhus @jonleung @IssueHuntBot