-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spell-checking #1336
Add spell-checking #1336
Conversation
this is great. any way to specify language, or use few? (seems not to be available from context menu, but perhaps when compiling?) |
@alekksander I think it will use the language of your system. |
@sindresorhus it does, so it's english, but i type in different language more frequently |
With this commit, you can select custom spell checkers alongside system default. The option is kept in Given the way API's are exposed in electron, Custom languages cannot be selected on MacOS as mentioned in the Note here. |
Please check now if the error still exists. Also, as we are using |
i confirm it works without JS error now, but the issue with preferred language, or rather not being able to choose one is ofc still existing. is there a way to have multiple languages to choose from? |
This indeed was the commit which should have worked (be it for multiple languages), doesn't the languages you have selected show up in spell-check? Does the spell-checker atleast change to show suggestions for one language (perhaps the first language)? |
spell checking works good for the language that is selected, and stops working when it's not selected. it all works fast and properly. the list of languages however is still not populated. perhaps someone else could try it out so we rule out my system specific configuration? edit:
or
or
and so on… |
Now user gets a complete list of languages and the end user can choose from this list. Check if this works @alekksander. @sindresorhus any comments on the PR? |
i couldn't as for more. works perfectly even with few languages selected. thank You for the interest and sorry i wasn't able to actually commit (no skills) |
These should do. |
This closes #14 which was long due and was waiting for sindresorhus/electron-context-menu#11
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor