Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement spell checking #14

Closed
fregante opened this issue Sep 24, 2015 · 35 comments · Fixed by #1336
Closed

Implement spell checking #14

fregante opened this issue Sep 24, 2015 · 35 comments · Fixed by #1336
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@fregante
Copy link

fregante commented Sep 24, 2015

Issuehunt badges

All apps on OS X can use the system's spellchecker, but it appears to be disabled in Caprine


IssueHunt Summary

nautatva nautatva has been rewarded.

Backers (Total: $65.00)

Submitted pull Requests


Tips

@sindresorhus
Copy link
Owner

I opened an Electron issue regarding this → electron/electron#3189

@sindresorhus
Copy link
Owner

Follow-up issue → electron/electron#3211

@dudeofawesome
Copy link
Contributor

Has there been any progress on this?

I might try to tackle it using electron-spellchecker.

@sindresorhus
Copy link
Owner

@dudeofawesome No progress. A pull request would be lovely. I think it should be added to electron-context-menu though, as it's what Caprine uses for the context menu, and that way it would benefit many apps, not just Caprine.

@nahive
Copy link

nahive commented Feb 23, 2017

Any progress on that? I'm using macOS text replacement keyboard feature and it's the only thing blocking me from using Caprine. I don't think that context menu will fix that - as it's an dynamic spell checking feature.

@akashnimare
Copy link

I have been using spellchecker for a while and it's pretty awesome. Works on all platforms.

@akashnimare
Copy link

@sindresorhus let me know if you're up for spellchecker.
Note - this module have default context menu options like - copy, paste etc so you gotta remove electron-context-menu to use it.

@sindresorhus sindresorhus changed the title Spell checking disabled on OS X Spell checking disabled on macOS May 13, 2017
@archcorsair
Copy link

Looks like there's been no progress made on this. I will have a go at it using spellchecker

@sindresorhus
Copy link
Owner

@archcorsair Awesome :) Note: #14 (comment)

@archcorsair
Copy link

archcorsair commented Jul 5, 2017

Here's the PR for spell checking support: #246

@nahive
Copy link

nahive commented Jul 31, 2017

Any progress on that? I'd love to use text replacements in caprine.

@fregante
Copy link
Author

fregante commented Jul 31, 2017

I don't think you'll ever be able to use text replacements, even Chrome doesn't support them (as a consequence of hacking the spellcheck support on instead implementing it fully.)

@archcorsair
Copy link

archcorsair commented Jul 31, 2017

I have a personal branch that has spellchecker support fully implemented/functional. I haven't had the time to fully implement it into @sindresorhus's electon-context-menu. With his permission, I can post a link to my personal build (for those who really want spellcheck support asap in caprine) until we get the context-menu issue resolved.

@willashley23
Copy link

Can I get an update on where we are at with this? Seems like electron-spellchecker isn't an option, what other options do we have? I'd be down to give it a shot!

@Mattiaslndstrm
Copy link

I'm also very interested in this.

@thatchrismiller
Copy link

Maybe I'm wrong, but I swear that spellcheck was present until the last update. It showed up in the edit menu. Now, it's gone.

@willashley23
Copy link

Any update on the status of this?

@kecinzer
Copy link

I still can't see spellchecker. It's there any progress on it?

@sindresorhus sindresorhus changed the title Spell checking disabled on macOS Implement spell checking Mar 15, 2019
This was referenced Mar 15, 2019
@sindresorhus sindresorhus pinned this issue Mar 15, 2019
@IssueHuntBot
Copy link

@IssueHunt has funded $60.00 to this issue.


@JoniVR
Copy link
Contributor

JoniVR commented Apr 6, 2019

I don't think you'll ever be able to use text replacements, even Chrome doesn't support them (as a consequence of hacking the spellcheck support on instead implementing it fully.)

You can use Alfred for this, it works in chrome (and thus Electron apps too)

@btrd
Copy link

btrd commented Apr 8, 2019

Why electron-spellchecker isn't an option ?

I can give it a try if it's a good option

@IssueHuntBot
Copy link

@hazrpg has funded $5.00 to this issue.


@hazrpg
Copy link

hazrpg commented Apr 18, 2019

Could this not be used as an option: https://www.npmjs.com/package/spellchecker

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 10, 2019
@alshdavid
Copy link

alshdavid commented Jun 14, 2019

Just a quick note, I was experimenting and registered Grammarly as an extension. While it registered just fine, it seems there are some issues with Electron support.

@matthewknill
Copy link

Any progress on this? I'd very much like to have a spell checker in this app...

@CvX
Copy link
Collaborator

CvX commented Nov 3, 2019

Coming to Electron 8.0! electron/electron#20692 🎉

@ncuben1775
Copy link

@sindresorhus @nautatva any progress on this?

@alekksander
Copy link

what's the issue state?

@myspivey
Copy link

Follow this PR for updates everyone sindresorhus/electron-context-menu#94

@issuehunt-oss
Copy link

issuehunt-oss bot commented May 12, 2020

@sindresorhus has rewarded $58.50 to @nautatva. See it on IssueHunt

  • 💰 Total deposit: $65.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $6.50

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels May 12, 2020
@sindresorhus
Copy link
Owner

@maxoku
Copy link

maxoku commented May 12, 2020

Would it be possible to combine dictionaries or only one language spell-checking at a time is possible?

@alekksander
Copy link

it's possible already – excluding mac os it seems, where it chooses one automatically. i don't know much about mac, but perhaps it's possible to navigate to Caprine/Preferences with file browser? if so, try editing this file and manually set it to something like

{"spellcheck":{"dictionaries":["pl","en-US"],"dictionary":""}}

where You write Your preferred language codes instead of ones in my example ("pl" "en-US")

@maxoku
Copy link

maxoku commented May 12, 2020

@alekksander
It works, thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.