Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the "Show Tray Icon" preference #1215

Merged
merged 6 commits into from
Feb 5, 2020
Merged

Fix the "Show Tray Icon" preference #1215

merged 6 commits into from
Feb 5, 2020

Conversation

JBudny
Copy link
Contributor

@JBudny JBudny commented Dec 12, 2019

System: Windows 7
Fixed problem: File->Caprine Settings->Show Tray Icon option wasn't working.

@sindresorhus
Copy link
Owner

Can you move the toggle logic into a function and also apply it here:

caprine/source/menu.ts

Line 348 in a6c914e

sendAction('toggle-tray-icon');
?

@sindresorhus
Copy link
Owner

Also run $ npm test locally and ensure the linting passes.

@JBudny JBudny mentioned this pull request Jan 8, 2020
Closed
sindresorhus
sindresorhus requested changes Jan 16, 2020
View reviewed changes
source/config.ts Outdated Show resolved Hide resolved
source/util.ts Outdated Show resolved Hide resolved
source/util.ts Outdated Show resolved Hide resolved
@JBudny JBudny mentioned this pull request Jan 30, 2020
Closed
@JBudny JBudny requested a review from sindresorhus January 30, 2020 20:31
@sindresorhus sindresorhus changed the title Fix the Show Tray Icon option from the preferencesSubmenu. Fix the "Show Tray Icon" preference Feb 5, 2020
@sindresorhus sindresorhus merged commit b386b23 into sindresorhus:master Feb 5, 2020
@sindresorhus
Copy link
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JBudny @sindresorhus