-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show tray icon not work #1241
Comments
// @JBudny |
Are you sure it was working on 2.41.0? Because I've picked this issue on 2.41.1 and back then for me it wasn't. I believe I fixed this issue on #1215. |
Yes, I'm completely sure about it, 100%. I haven't had this icon in tray and always opened Caprine by pinned icon om my taskbar. Otherwise, I should notice it. It automatically appeared in tray with upgrading to 2.42 and no way to disable it since the option to show/hide doesn't work. Maybe it has something to do with lack of notifications when received a message. I don't get any notification, hear only a "pling" and the icon changes it's colour from gray to blue. I was getting Action Center notifications/popups on 2.41 and no tray icon. |
Thank you for detailed feedback, I think I get it right now. The tray icon wasn't showing when 'Show tray icon' and 'Quit on Window Close' was on. |
'Quit on Window Close' as well as 'Show Tray Icon' are both set to off. Strange, I started to receive notifications about new messages near the date & time but they aren't visible in Action Center, (without Caprine update and changing any setting), though they're set to be visible in Action Center on my Windows 10 1909 updated machine. |
I dug up a little into that issue and it looks like as I said before it's related to #1217, but I didn't described it well enough when I was opening the issue. That fix not only applies when 'Show Tray Icon' and 'Quit on Window Close' are on but also when 'Launch Minimized' is on or app window is open as hidden. Do you use 'Launch Minimized' or any similar feature hiding the main app window? On the other hand, I fixed tray icon toggle functionality on #1215 (not released yet), but I locked the possibility to hide tray icon along with 'launch minimized' setting on because I considered these settings mutually exclusive (hidden tray icon and launching minimized = no default way to maximize the window). Right now you can't use 'launch minimized' setting along with hidden tray icon, but if #1215 will get accepted and merged you'll be able to use a fully functional tray icon instead. Tell me please what do you think of that solution. If something isn't user-friendly in your opinion I'll try to fix it. |
I've managed to reproduce the 5th process issue in the task manager. It's probably because the pinned icon is a shortcut to run the application and instead maximizing it's opening the app again. I couldn't reproduce the issue for the tray icon. |
Tray icon is not present on Linux systems since version v2.44. |
It looks like it's related to the updated |
See summary here. |
I can't agree with this point of the summary. Tray icon is missing as well (Manjaro 19.0.1, Plasma 5.17.5) |
Tray icon is missing for me on latest caprine 2.44.0-1790 but works on 2.43.0-1772 |
@sebastianpaweska, I've authored above message. So according to the original message |
I've just found out that Electron is restoring an old implementation of tray icons that was removed from Chromium in Electron v8. PR: 23674 |
electron/electron#23674 has been merged |
This is related to the missing icon due to Chromium but and as that is fixed and icon is present again I will close this issue. |
"Show tray icon" in settings doesn't work and haven't any impact after update to 2.42. Tray icon is always visible and can't be hidden as in 2.41
Caprine 2.42.0
Electron 7.1.9
win32 10.0.18363
Locale: sv
The text was updated successfully, but these errors were encountered: