-
-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python in Learning #1961
Add Python in Learning #1961
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
Thanks, Sindre Sorhus! I will view it, but i have to say something: the list is not mine. In my first menssage i say it, "in colaboration with quobit". quobit is the creator of this list, i'm only, with his permission, making this pull request. If the list breaks your guidelines that is the problem of his creator. If this pull request is the thing that breaks you guidelines, please, let's me know it. |
I recommend contact the list creator in this issue, why here is where i'm advise the changes with this pull request. |
Hi Danix. If you want this pull request to be merged, the repository you suggest must meet the requirements. Awesome-lint can help to find some things to fix:
|
Thanks, but, i have to say again, i'm not the creator of Awesome Python in Learning, i'm colaborating with his creator to put it in Awesome. I send a menssage to the list creator to use it, thanks. |
Thanks, Kikobeats, but i say again, i'm NOT the creator of Awesome Python in Education, i'm colaborating with his creator to add it to Awesome. Please, contact the list creator here, where i'm talking about the status of this pull request. |
It looks like he is not available for contact, so it's possible that this request will be closed why the list don't meets the guidelines |
@Danix421 what if you fork the list? |
I can do it, but the list owner is now busy, it can't respond the menssages |
@Danix421 ghhzj |
What? |
You need to read the contribution guidelines very carefully, and execute them to the letter. The problem is not only that the list isn't completely following the standards, but also this PR. You can fork the list and fix the problems and make a PR to the list. Its not an issue that you are not the author. Github is about collaboration (and its even better that you are not the author, because its at least not self promotion). |
Ok, i already made a pull request to "try" to fix an error but the list creator is not available. So, i will only fix the errors in this pull request. |
Ok, @sindresorhus, i think it is know fixed. The list creator has fixed the master branch error, and others things. If i looked good, there is an error in my pull request: the name of it. I already fixed it and well, i will review the others pull requests. So, i think i don't have to change the pull request first comment, why already has passed too much time, but if it's neccesary i will do it. So, i hope that all the things are good. |
I think you have to use the template: https://github.com/sindresorhus/awesome/blob/main/pull_request_template.md |
Ok, i will do it |
Ok, @Jogai, i did it. It's time for @sindresorhus review my pull request |
I'm not trying to annoy you, but you still didn't follow every point on the list. Just using the template isn't enough, you have to actually follow it. |
I know it and i'm trying to do it, even if the list is not mine. And, i think that my pull request don't have any errors, if it have, i waiting for @sindresorhus. |
I know, that's why I'm trying to help you. I don't even have a PR open for which I have to do this. |
Well, thanks! |
Well, i think this pull request has to be closed, why it have too much time active and i don't know if i'm breaking an Awesome rule |
Python in Learning
Python in learning is a list of Python learning resources, like tutorials, webpages and others, game engines, like Ursina Engine, Panda3D and others, and more!
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.