Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Adding Awesome Python in Education to Awesome #36

Closed
ghost opened this issue Mar 7, 2021 · 10 comments
Closed

Adding Awesome Python in Education to Awesome #36

ghost opened this issue Mar 7, 2021 · 10 comments

Comments

@ghost
Copy link

ghost commented Mar 7, 2021

Hi Awesome Python in Learning, i'm Danix, a developer. I viewed that this Awesome list is not in the big Awesome list. I wan't to contribute (again) to this list by creating a pull request in the big Awesome list to add this to it! (I think) this will make Awesome Python in Education more famous, why the big Awesome list is the original Aweosme, the Awesome of the Awesomes. Well, i hope Awesome Python in Education give me permission to do it!

@quobit
Copy link
Owner

quobit commented Mar 7, 2021

Of course! Although it would be also interesting appearing in vinta/awesome-python

@ghost
Copy link
Author

ghost commented Mar 7, 2021

Ok, i will advise in this way when i open the pull request in Awesome and when (if they like it) accept it. In vinta/awesome-python i will do it too! Thanks.

@ghost
Copy link
Author

ghost commented Mar 7, 2021

Well, i already have a pull request in vinta/awesome-python so i will add this commit to it! You can view it here. Please, view it and add vote, why i'm waited for more of 10 days for a review and it don't have one why vinta only wan't to review a pull request that haves minimum 20 votes.

@ghost
Copy link
Author

ghost commented Mar 7, 2021

The Awesome pull request is now created. You can view it here.

@ghost
Copy link
Author

ghost commented Mar 8, 2021

Sorry, quobit, but the Awesome creator, sindresorhus, saw that your list don't meet his guidelines to be displayed in his Awesome. Sorry again, but you will have to modify your list to meet the guidelines. Someone in my pull request has saw to use something named Awesome Lint to know what are the requirements that your list don't meet. You can view his menssage here to do the changes.

@ghost
Copy link
Author

ghost commented Mar 10, 2021

I look in the Awesome guidelines and the lists principal branch has to be named "main", and this list principal branch is named "master". For add this list to Awesome, you need to change the branch name. i already create a pull request in this list to fix it, i think.

@ghost
Copy link
Author

ghost commented Mar 10, 2021

This is the pull request that fix it, i think.

@ghost
Copy link
Author

ghost commented Mar 18, 2021

Sorry, @quobit but the owner of Awesome closed the Awesome Python in Education pull request, i think that was why we breaked some of the Awesome guidelines. The vinta/awesome-python pull request has not closed but it has too much time open and vinta don't review it, so, that are bad news.

@ghost ghost closed this as completed Mar 27, 2021
@ghost
Copy link
Author

ghost commented Mar 27, 2021

Sorry, @quobit, but were is not respond from vinta, so i will close the pull request

@quobit
Copy link
Owner

quobit commented Mar 27, 2021

No problem at all. Thank you for your interest

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant