Minimal fix for warnings #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged and will be part of the next release. Thanks for your effort! I'll add some further comment into #106 |
jperkin
pushed a commit
to TritonDataCenter/pkgsrc-legacy
that referenced
this pull request
Dec 9, 2013
v0.6.4, 2012-05-10 ([changes](simplecov-ruby/simplecov@v0.6.3...v0.6.4)) ------------------- * [BUGFIX] Encoding issues with ISO-8859-encoded source files fixed. See simplecov-ruby/simplecov#117. (thanks to @Deradon) * [BUGFIX] Ensure ZeroDivisionErrors won't occur when calculating the coverage result, which previously could happen in certain cases. See simplecov-ruby/simplecov#128. (thanks to @japgolly) * [REFACTORING] Changed a couple instance variable lookups so SimpleCov does not cause a lot of warnings when running ruby at a higher warning level. See simplecov-ruby/simplecov#106 and simplecov-ruby/simplecov#119. (thanks to @mvz and @gioele) v0.6.3, 2012-05-10 ([changes](simplecov-ruby/simplecov@v0.6.2...v0.6.3)) ------------------- * [BUGFIX] Modified the API-changes for newer multi_json versions introduced with #122 and v0.6.2 so they are backwards-compatible with older multi_json gems in order to avoid simplecov polluting the multi_json minimum version requirement for entire applications. See simplecov-ruby/simplecov#132 * Added appraisal gem to the test setup in order to run the test suite against both 1.0 and 1.3 multi_json gems and ensure the above actually works :)
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Oct 11, 2014
v0.6.4, 2012-05-10 ([changes](simplecov-ruby/simplecov@v0.6.3...v0.6.4)) ------------------- * [BUGFIX] Encoding issues with ISO-8859-encoded source files fixed. See simplecov-ruby/simplecov#117. (thanks to @Deradon) * [BUGFIX] Ensure ZeroDivisionErrors won't occur when calculating the coverage result, which previously could happen in certain cases. See simplecov-ruby/simplecov#128. (thanks to @japgolly) * [REFACTORING] Changed a couple instance variable lookups so SimpleCov does not cause a lot of warnings when running ruby at a higher warning level. See simplecov-ruby/simplecov#106 and simplecov-ruby/simplecov#119. (thanks to @mvz and @gioele) v0.6.3, 2012-05-10 ([changes](simplecov-ruby/simplecov@v0.6.2...v0.6.3)) ------------------- * [BUGFIX] Modified the API-changes for newer multi_json versions introduced with #122 and v0.6.2 so they are backwards-compatible with older multi_json gems in order to avoid simplecov polluting the multi_json minimum version requirement for entire applications. See simplecov-ruby/simplecov#132 * Added appraisal gem to the test setup in order to run the test suite against both 1.0 and 1.3 multi_json gems and ensure the above actually works :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits turn on warnings to demonstrate issue #106, and then fix the warnings emitted by
rake test. I have attempted to keep the changes as minimal as possible; they basically boil down do inserting adefined?here and there.Note: shoulda (or shoulda-context depending on which version is in your Gemfile.lock) will still emit some warnings during the running of the tests.