Loosen multi_json dependency #132
Assignees
Labels
Comments
colszowka
added a commit
that referenced
this issue
May 10, 2012
Original source for the updated API was #122. Also see sferik/rails@5e62670 for the source implementation of this.
Merged
ghost
assigned
colszowka
added a commit
that referenced
this issue
May 10, 2012
…ions. Also updated developer instructions in README and test setup both for local and CI. This became neccessary to ensure that older versions of multi_json are supported, see #132.
|
Thanks. I had never heard of appraisal before. I'll have to check that out. |
|
Version 0.6.3 is out and should fix this problem, thanks for the report. |
jperkin
pushed a commit
to TritonDataCenter/pkgsrc-legacy
that referenced
this issue
Dec 9, 2013
v0.6.4, 2012-05-10 ([changes](simplecov-ruby/simplecov@v0.6.3...v0.6.4)) ------------------- * [BUGFIX] Encoding issues with ISO-8859-encoded source files fixed. See simplecov-ruby/simplecov#117. (thanks to @Deradon) * [BUGFIX] Ensure ZeroDivisionErrors won't occur when calculating the coverage result, which previously could happen in certain cases. See simplecov-ruby/simplecov#128. (thanks to @japgolly) * [REFACTORING] Changed a couple instance variable lookups so SimpleCov does not cause a lot of warnings when running ruby at a higher warning level. See simplecov-ruby/simplecov#106 and simplecov-ruby/simplecov#119. (thanks to @mvz and @gioele) v0.6.3, 2012-05-10 ([changes](simplecov-ruby/simplecov@v0.6.2...v0.6.3)) ------------------- * [BUGFIX] Modified the API-changes for newer multi_json versions introduced with #122 and v0.6.2 so they are backwards-compatible with older multi_json gems in order to avoid simplecov polluting the multi_json minimum version requirement for entire applications. See simplecov-ruby/simplecov#132 * Added appraisal gem to the test setup in order to run the test suite against both 1.0 and 1.3 multi_json gems and ensure the above actually works :)
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this issue
Oct 11, 2014
v0.6.4, 2012-05-10 ([changes](simplecov-ruby/simplecov@v0.6.3...v0.6.4)) ------------------- * [BUGFIX] Encoding issues with ISO-8859-encoded source files fixed. See simplecov-ruby/simplecov#117. (thanks to @Deradon) * [BUGFIX] Ensure ZeroDivisionErrors won't occur when calculating the coverage result, which previously could happen in certain cases. See simplecov-ruby/simplecov#128. (thanks to @japgolly) * [REFACTORING] Changed a couple instance variable lookups so SimpleCov does not cause a lot of warnings when running ruby at a higher warning level. See simplecov-ruby/simplecov#106 and simplecov-ruby/simplecov#119. (thanks to @mvz and @gioele) v0.6.3, 2012-05-10 ([changes](simplecov-ruby/simplecov@v0.6.2...v0.6.3)) ------------------- * [BUGFIX] Modified the API-changes for newer multi_json versions introduced with #122 and v0.6.2 so they are backwards-compatible with older multi_json gems in order to avoid simplecov polluting the multi_json minimum version requirement for entire applications. See simplecov-ruby/simplecov#132 * Added appraisal gem to the test setup in order to run the test suite against both 1.0 and 1.3 multi_json gems and ensure the above actually works :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I commented on b496fd3, but please loosen the multi_json dependency. Simplecov uses it as a transitive dependency, but a lot of other libraries do as well, so it affects an entire dependency tree. Relying on the new API is no less a breaking change than go straight to multi_json 2.0. Feature detection of the APIs would mitigate against this. In any event, at the very least the move shouldn't happen in a point release.
The text was updated successfully, but these errors were encountered: