[beater] Package restructure #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partially implements elastic#2142
Related to elastic#2489
axw
reviewed
Jul 26, 2019
|
Thank you @axw for all the valuable feedback, much appreciated. I made according changes. One thing that still bothers me is the handling in request/result.go. I see if I can come up with something else there. |
simitt
force-pushed
the
2489-context-response
branch
2 times, most recently
from
26a4b94 to
4bb3cfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures the beater package into separate smaller packages for cleaner separation of concerns.
The PR is created against another branch that already took care of changing log handler, monitoring handler and response handling, to only address the restructuring of the package. The only changed functionality is related to monitoring handlers.
Tests are not changed, as this draft PR is meant to get some feedback on the structure before splitting up and properly adjust all the tests.
This PR is related to Issue elastic#2489 and builds on top of elastic#2492 , elastic#2493 , elastic#2494 .