Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework request and response counters #2142

Closed
simitt opened this issue Apr 23, 2019 · 1 comment
Closed

Rework request and response counters #2142

simitt opened this issue Apr 23, 2019 · 1 comment
Assignees
@simitt
Milestone
7.4

Comments

@simitt
Copy link
Contributor

simitt commented Apr 23, 2019 •
edited
Loading

At the moment the request and response counters, as well as the log entries for requests and responses are spread between the various handler files in the beater directory.

I suggest to move the logic to a central place and wrap all requests with it. We already have a logHandler wrapped around requests. This log handler should be adapted so that it also has access to errors. See if recordingResponseWriter can be adapted and used for this.

For the counters we should add something similar, by adding a dedicated counterHandler that ensures all the counters are set properly and removes the clutter from the beater package.

While on it, we could add system tests to check that logs actually contain expected log messages, as the testing for logs is rather sparse.

Update:
This issue has been split into 2 issues. Everything concerning improvements of the log handling has been moved to #2201.
@jalvz jalvz mentioned this issue Apr 30, 2019
Merged
@jalvz
Copy link
Contributor

jalvz commented May 1, 2019

oh sorry, wrong link :(

@jalvz jalvz reopened this May 1, 2019
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels May 1, 2019
@graphaelli graphaelli added this to the 7.3 milestone Jun 11, 2019
@graphaelli graphaelli changed the title Rework request and response counters and log entries Rework request and response counters Jun 11, 2019
@simitt simitt mentioned this issue Jun 12, 2019
Closed
@jalvz jalvz self-assigned this Jun 12, 2019
@jalvz jalvz removed their assignment Jul 5, 2019
@graphaelli graphaelli removed this from the 7.3 milestone Jul 18, 2019
@simitt simitt mentioned this issue Jul 23, 2019
Closed
8 tasks
@graphaelli graphaelli added this to the 7.4 milestone Jul 23, 2019
@simitt simitt self-assigned this Jul 23, 2019
simitt added a commit to simitt/apm-server that referenced this issue Jul 24, 2019
@simitt
Refactor monitoring handling
34b03f2 
partially implements elastic#2142
simitt added a commit to simitt/apm-server that referenced this issue Jul 24, 2019
@simitt
Refactor monitoring handling
b0b5ca3 
partially implements elastic#2142
simitt added a commit to simitt/apm-server that referenced this issue Jul 24, 2019
@simitt
Refactor monitoring handling
4c24607 
partially implements elastic#2142
@simitt simitt mentioned this issue Jul 24, 2019
Merged
simitt added a commit to simitt/apm-server that referenced this issue Jul 24, 2019
@simitt
Refactor monitoring handling
e2776c2 
partially implements elastic#2142
simitt added a commit to simitt/apm-server that referenced this issue Jul 30, 2019
@simitt
Refactor monitoring handling
46b1439 
partially implements elastic#2142
simitt added a commit to simitt/apm-server that referenced this issue Jul 30, 2019
@simitt
Refactor monitoring handling
a9b1244 
partially implements elastic#2142
simitt added a commit to simitt/apm-server that referenced this issue Jul 30, 2019
@simitt
Refactor monitoring handling
cd7e7c0 
partially implements elastic#2142
simitt added a commit that referenced this issue Jul 30, 2019
@simitt
[beater] Introduce middleware logic and dedicated monitoring middlewa…
88513e3 
…re (#2493)

partially implements #2142
simitt added a commit to simitt/apm-server that referenced this issue Aug 7, 2019
@simitt
Use separate monitoring counter per API
4c97eae 
Introduce dedicated monitoring counter for root, sourcemap upload,
intake and agent config API.

implements elastic#2142
This was referenced Aug 7, 2019
Merged
Merged
simitt added a commit to simitt/apm-server that referenced this issue Aug 7, 2019
@simitt
[beater] Introduce middleware logic and dedicated monitoring middlewa…
cd91764 
…re (elastic#2493)

partially implements elastic#2142
simitt added a commit to simitt/apm-server that referenced this issue Aug 7, 2019
@simitt
Use separate monitoring counter per API
15d0df6 
Introduce dedicated monitoring counter for root, sourcemap upload,
intake and agent config API.

implements elastic#2142
simitt added a commit that referenced this issue Aug 20, 2019
@simitt @graphaelli
[beater] Refactor beater package (#2526)
6e7bab6 
* [beater] Add context handlers and adapt log handling (#2492 )

related to #2201

* [beater] Introduce middleware logic and dedicated monitoring middleware (#2493)

partially implements #2142

* [beater] Improve Response Writing (#2494)

Change response write handling to set a response per context and then call write on the context. Introduce a shared beatertest package with testing helper structs and methods.

related to #2489

* [beater] Restructure beater package (#2518)

Create several packages inside the beater directory to better organize http framework logic. Adapt tests and code to new structure.

related to #2489

* More beater coverage (#2582)

Co-Authored-By: Gil Raphaelli <[email protected]>
simitt added a commit to simitt/apm-server that referenced this issue Aug 20, 2019
@simitt
Use separate monitoring counter per API
86c65f0 
Introduce dedicated monitoring counter for root, sourcemap upload,
intake and agent config API.

implements elastic#2142
simitt added a commit to simitt/apm-server that referenced this issue Aug 20, 2019
@simitt @graphaelli
[beater] Refactor beater package (elastic#2526)
7692ad1 
* [beater] Add context handlers and adapt log handling (elastic#2492 )

related to elastic#2201

* [beater] Introduce middleware logic and dedicated monitoring middleware (elastic#2493)

partially implements elastic#2142

* [beater] Improve Response Writing (elastic#2494)

Change response write handling to set a response per context and then call write on the context. Introduce a shared beatertest package with testing helper structs and methods.

related to elastic#2489

* [beater] Restructure beater package (elastic#2518)

Create several packages inside the beater directory to better organize http framework logic. Adapt tests and code to new structure.

related to elastic#2489

* More beater coverage (elastic#2582)

Co-Authored-By: Gil Raphaelli <[email protected]>
simitt added a commit that referenced this issue Aug 20, 2019
@simitt @graphaelli
[beater] Refactor beater package (#2526) (#2597)
5dbe6f0 
* [beater] Add context handlers and adapt log handling (#2492 )

related to #2201

* [beater] Introduce middleware logic and dedicated monitoring middleware (#2493)

partially implements #2142

* [beater] Improve Response Writing (#2494)

Change response write handling to set a response per context and then call write on the context. Introduce a shared beatertest package with testing helper structs and methods.

related to #2489

* [beater] Restructure beater package (#2518)

Create several packages inside the beater directory to better organize http framework logic. Adapt tests and code to new structure.

related to #2489

* More beater coverage (#2582)

Co-Authored-By: Gil Raphaelli <[email protected]>
simitt added a commit that referenced this issue Aug 22, 2019
@simitt
[monitoring] Use separate monitoring counter per API (#2527)
707ecdc 
* Use separate monitoring counter per API

Introduce dedicated monitoring counter for root, sourcemap upload,
intake and agent config API.

implements #2142
simitt added a commit to simitt/apm-server that referenced this issue Aug 22, 2019
@simitt
[monitoring] Use separate monitoring counter per API (elastic#2527)
e86e1ea 
* Use separate monitoring counter per API

Introduce dedicated monitoring counter for root, sourcemap upload,
intake and agent config API.

implements elastic#2142
@simitt simitt closed this as completed Aug 23, 2019
simitt added a commit that referenced this issue Aug 23, 2019
@simitt
[7.x] [monitoring] Use separate monitoring counter per API (#2527) (#…
2a777d5 
…2618)

* [monitoring] Use separate monitoring counter per API (#2527)

* Use separate monitoring counter per API

Introduce dedicated monitoring counter for root, sourcemap upload,
intake and agent config API.

implements #2142

* Fix approval test
This was referenced Aug 26, 2019
Closed
Closed
@cachedout cachedout mentioned this issue Sep 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simitt simitt

Labels
None yet
Projects
None yet
Milestone
7.4
Development

No branches or pull requests
3 participants
@graphaelli @jalvz @simitt