Add typings for DataUrl #3968
Merged
Add typings for DataUrl #3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
commented
Nov 22, 2023
| assert(file_path is None) | ||
| assert(data_path is None) | ||
| assert(data_slice is None) | ||
| assert(scheme is None) |
There was a problem hiding this comment.
Some changes are due to auto-formatting by black. Sorry !
EDIT: I guess it is fine in the end: #3819
| """ | ||
| self.__path = path | ||
| # only replace if ? not here already. Otherwise can mess sith | ||
| # data_slice if == ::2 for example | ||
| if '?' not in path: | ||
| if "?" not in path: |
|
|
||
| :rtype: str | ||
| """ | ||
| def data_path(self) -> str | None: |
There was a problem hiding this comment.
data_path can be None if path is used to construct the DataUrl.
loichuder
force-pushed
the
data-url-typings
branch
2 times, most recently
from
a0c2677 to
8e48652
Compare
loichuder
commented
Nov 22, 2023
| return self.__data_path | ||
|
|
||
| def data_slice(self): | ||
| def data_slice(self) -> tuple[SliceLike, ...] | None: |
There was a problem hiding this comment.
data_slice can also be None if no slice is specified.
loichuder
force-pushed
the
data-url-typings
branch
2 times, most recently
from
120f133 to
df0d1e0
Compare
loichuder
force-pushed
the
data-url-typings
branch
from
df0d1e0 to
aead106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.