Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using black formatting #3819

Closed
t20100 opened this issue May 11, 2023 · 3 comments · Fixed by #3991
Closed

Using black formatting #3819

t20100 opened this issue May 11, 2023 · 3 comments · Fixed by #3991
Assignees
Milestone

Comments

@t20100
Copy link
Member

t20100 commented May 11, 2023

What about using black now that it is stable and a standard tool?

By using Black, you agree to cede control over minutiae of hand-formatting. In return, Black gives you speed, determinism, and freedom from pycodestyle nagging about formatting. You will save time and mental energy for more important matters.

Personally, I'd make it checked by CI... but I'm also OK to convert the code base and fix it once in a while.

What do you think?

@vallsv
Copy link
Contributor

vallsv commented May 11, 2023

Up to you.

I think it will be mostly fine expect at some places.

I also don't like CI check for such thing, but it's up to you. You'r the main maintainer.

Finally it will also break the whole previous open PR, but there is not so much remaining ones.

@t20100
Copy link
Member Author

t20100 commented May 11, 2023

I also don't like CI check for such think

The issue when partly using black is ending with PRs polluted by some reformatting.

Now, in practice with the current activity of the project, that shouldn't be a big deal...
And even less if it is set on save in the IDE or as a pre-commit hook.
So as I said, it's OK for me not to have it in the CI.

Finally it will also break the whole previous open PR

Yes, it's best to do so with no PRs opened.

@t20100 t20100 added this to the 2.0.0 milestone Jun 7, 2023
@t20100 t20100 removed the question label Jun 7, 2023
@t20100
Copy link
Member Author

t20100 commented Jun 7, 2023

Let's black the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants