UserFormFileExtension

[emteknetnz]

Extension method implementation to check if a file is a userform file upload

Related PR: silverstripe/silverstripe-assets#398

Issue silverstripe/silverstripe-asset-admin#1066

[Cheddam]

A couple of suggestions, but otherwise looking good. I've recommended an adjustment to the naming of the new API this relies on, so I'll hold off on approving this until that's resolved and this PR is updated (if necessary).

[dhensby]

Something about this approach feels off. Why aren't we using the pre-existing relationship between SubmittedFileField and File to determine if they belong to a UserForm?

if ($file->UploadField()->exists()) {
   return true;
}

All this would need is to add a config value of:

SilverStripe\Assets\File:
  belongs_to:
    UploadField: SilverStripe\UserForms\Model\Submission\SubmittedFileField

[emteknetnz]

@dhensby have updated to use $file->SubmittedFileField()->exists()

[Cheddam]

I've provided some additional thoughts on Dan's outstanding feedback, but basically I think this is good to go now.

@emteknetnz Take a quick look at the second one and see if you agree with my suggestion, otherwise let's merge.

[dhensby]

My overall point here is why are we adding a new field that de-normalises this information when it can be worked out from existing database relationships.

We know which files were uploaded from formfields by seeing if there is a relationship with an EditableFormField.

We can replace all this entire PR with:

public function getUserFormUpload() {
    return $value = $file->SubmittedFileField()->exists();
}

[dhensby]

The hardcoded column name isn't ideal, perhaps this could be a class constant that's used in the $db array? Otherwise I think this can move forward as-is for now.

The correct way to do it would be to use DataObjectSchema