Methods to support file status icons #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
emteknetnz
force-pushed
the
pulls/1/file-manager-icons
branch
from
13be2c5 to
0199e36
Compare
Cheddam
requested changes
May 12, 2020
emteknetnz
force-pushed
the
pulls/1/file-manager-icons
branch
4 times, most recently
from
a7b6aaf to
c558a2b
Compare
|
Nice work, it’s pretty clear. I’ve left some questions and suggestions. Can you please also provide some unit tests for this, and write a short description of the API you’re adding for your commit message? |
Chur
I'm not seeing these, could you point me in the right direction? |
robbieaverill
suggested changes
May 21, 2020
|
Ha, whoops |
emteknetnz
force-pushed
the
pulls/1/file-manager-icons
branch
2 times, most recently
from
b3a2816 to
4927de6
Compare
dhensby
reviewed
May 21, 2020
- hasRestrictedAccess() -- member-less permission check on file - isTrackedFormUpload() -- file was uploaded via a form and tracked in db
emteknetnz
force-pushed
the
pulls/1/file-manager-icons
branch
from
4927de6 to
239c559
Compare
Cheddam
approved these changes
May 24, 2020
There was a problem hiding this comment.
I think this is good to go 👍
@robbieaverill Happy to proceed with merge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: silverstripe/silverstripe-asset-admin#1066
Old PR: https://github.com/silverstripe/silverstripe-assets/pull/386/files