Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling back to top after pressing PREV/NEXT buttons #1109

Merged
merged 3 commits into from
Sep 15, 2021

Conversation

myexistance
Copy link
Contributor

PR

@myexistance
Copy link
Contributor Author

@emteknetnz @maxime-rainville - anything else I need to do before you can accept this pull request?

The pull request system seemed a bit jittery - like the tests would not pass but then we ran it again with the same code and it passed. I feel this is an hurdle to getting more pull requests.

In any case, thank you so much for all your help. I am super excited if this would be able to be added to userforms.

Thanks a million.

Joon

@emteknetnz
Copy link
Member

@myexistance thanks for you contribution

Issue you experienced travis was probably an unrelated fix for userforms to do with trimming email addresses that was patched yesterday

I should get a chance later this week to have a look over this, and I'll run it past our UX designer to get his view

Thanks again

@emteknetnz
Copy link
Member

@clarkepaul here's a video of before and after - seems good to me, you happy with this?

https://www.youtube.com/watch?v=mlewS5balcY

@clarkepaul
Copy link

@emteknetnz yup looks good :).

@emteknetnz emteknetnz merged commit 6093179 into silverstripe:5 Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants