Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus should scroll to top of the form with Previous and Next buttons #905

Closed
brynwhyman opened this issue Sep 24, 2019 · 8 comments
Closed

Comments

@brynwhyman
Copy link

brynwhyman commented Sep 24, 2019

Overview

Currently when submitting a form on the frontend using the Prev, Next , Submit buttons, focus will not subsequently jump to the top of the form.

Without this there's the possibility the user misses fields on the form, or at the very least has to scroll to the top of the form which is unintuitive.

This seems like something that should be a part of the default bundle.

Versions affected

Identified on 5.3

Notes

@neilcreagh
Copy link

This is also an issue when the form is submitted on mobile as users can't see the confirmation message (unless it was a very short form/page) and have to scroll up to see it.

@sunnysideup
Copy link
Contributor

Would you accept a pull request for this issue?

@michalkleiner michalkleiner changed the title Focus should scroll to top when submitting on the frontend Focus should scroll to top of the form when submitting on the frontend Sep 9, 2021
@brynwhyman
Copy link
Author

@sunnysideup I'd be grateful for a pull request. I'm not a developer so I wouldn't be merging it, but hopefully someone can help.

@brynwhyman
Copy link
Author

PR: #1109

@emteknetnz
Copy link
Member

Linked PR has been merged, I'll close this one

@brynwhyman
Copy link
Author

The linked PR doesn't mention anything has been added on the 'Submit' action. Is someone able to please confirm if that's happened too?

@brynwhyman brynwhyman reopened this Sep 15, 2021
@sunnysideup
Copy link
Contributor

@brynwhyman - the submit should perhaps be a different ticket.

@brynwhyman brynwhyman changed the title Focus should scroll to top of the form when submitting on the frontend Focus should scroll to top of the form with Previous and Next buttons Sep 16, 2021
@brynwhyman
Copy link
Author

I'm happy to split off the 'submit' action to another issue and close this. I've updated the title and description of this issue to only focus on the 'Previous' and 'Next' buttons and will close it.

New issue for the submit button: #1112

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants