-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Use cached table list from ClassInfo #564
Conversation
Please retarget to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ahh, there's a merge conflict - can you please resolve that? |
ok should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The merge commit isn't ideal but I'll make sure to squash and merge so it should be fine.
Thanks for doing this.
Description
Fixes #563
Using ClassInfo::hasTable, the cached data is used and avoid extra query per request
Manual testing steps
Install debugbar
Install subsite module
Check that no extra query is made
Issues
Pull request checklist