We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x
Currently, the middleware make a table check on each request. While not super expensive, it feels that this is really unecessary
Related issues:
silverstripe/silverstripe-framework#11181 tractorcow-farm/silverstripe-fluent#828
Install debugbar Install subsite module Check the queries: a SHOW TABLES LIKE 'SubsiteDomain' happen in each query
Don't make the check except on dev/build: tractorcow-farm/silverstripe-fluent#831
Rely on the cached ClassInfo::hasTable instead which will get even better in the future silverstripe/silverstripe-framework#11183
No response
silverstripe/installer
The text was updated successfully, but these errors were encountered:
Pr is merged
Sorry, something went wrong.
GuySartorelli
Successfully merging a pull request may close this issue.
Module version(s) affected
3.x
Description
Currently, the middleware make a table check on each request. While not super expensive, it feels that this is really unecessary
Related issues:
silverstripe/silverstripe-framework#11181
tractorcow-farm/silverstripe-fluent#828
How to reproduce
Install debugbar
Install subsite module
Check the queries: a SHOW TABLES LIKE 'SubsiteDomain' happen in each query
Possible Solution
Don't make the check except on dev/build:
tractorcow-farm/silverstripe-fluent#831
Rely on the cached ClassInfo::hasTable instead which will get even better in the future
silverstripe/silverstripe-framework#11183
Additional Context
No response
Validations
silverstripe/installer
(with any code examples you've provided)PRs
The text was updated successfully, but these errors were encountered: