-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR Update add_i18n_javascript to load lowercase-dash language files #8726
MINOR Update add_i18n_javascript to load lowercase-dash language files #8726
Conversation
9ee85ae
to
c6214b8
Compare
babb910
to
13486ca
Compare
Unit tests have been added and typo has been corrected. |
The typo has been fixed.
$backend->add_i18n_javascript('i18n'); | ||
|
||
$actual = $backend->getJavascript(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove duplicate blank lines.
@@ -1109,4 +1110,77 @@ protected function getBackendFiles($backend, $type) | |||
} | |||
return array(); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might pay to check that we don't load locales that are irrelevant.
We need a way to load MomentJS local files because of this issue silverstripe/silverstripe-admin#791.
MomentJS file formats are like
de-de
, while our current format isde_DE.js
.This update just add a few extra format to check for.
Parent issue