-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisions to DatetimeField
to have better HTML5 fallbacks
#791
Revisions to DatetimeField
to have better HTML5 fallbacks
#791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks OK. However, I'm not sure what part of the issue we are trying to fix here.
That makes it difficult to actually test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When accessing the Uploaded, Last Edited dates in asset admin, I'm still getting the en_US format in all browsers.
The underlying issue appears to be coming from this commit. silverstripe/silverstripe-framework@33a013a
@maxime-rainville I think this could be happening because of the member locale: Just tested on my computer and changing it seemed to fix the issue. |
daf3f46
to
cebb382
Compare
@bergice Tried siwtching to English UK and French. I'm always getting the date in en_US on this end. |
@maxime-rainville could you try overriding the locale in your |
There was a problem with MomentJS locale's not being loaded. They were included when the library was being compile without the I added a bit of code to the Webpack config that copies all the local files to the dist folder. I added a Requirements call to LeftAndMain to load the Moment Loclaes based on the current default Locale for the project and the Member's Locale. This fix relies on silverstripe/silverstripe-framework#8726 |
b3d8f7b
to
00f200c
Compare
…lverstripe-admin into pulls/1/date-locale-fix
@maxime-rainville I've made some further fixes on top of your fixes. Happy to merge this when you are. |
Everything is good. Failure is just cause because the lib hasn't been rebuild. I just rebuild locally and pushed up. I'll squash/merge on green. |
No description provided.