Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Add ValidationInterface to Form #11518

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Dec 19, 2024

Issue #11457

@emteknetnz emteknetnz force-pushed the pulls/6.0/valid-interface2 branch from aafa484 to 8fa56d1 Compare December 19, 2024 04:15
@emteknetnz emteknetnz marked this pull request as ready for review December 19, 2024 20:56
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #11515 (review) I mentioned there seem to be calls to validationResult() from other modules. Can you please check if that's still the case before I merge this?

tests/php/Forms/FormTest.php Show resolved Hide resolved
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 72f10d3 into silverstripe:6.0 Dec 19, 2024
13 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6.0/valid-interface2 branch December 19, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants