Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Use validate method instead of validationResult #11515

Merged
merged 1 commit into from
Dec 17, 2024
Merged

API Use validate method instead of validationResult #11515

merged 1 commit into from
Dec 17, 2024
+33 −23

Conversation

emteknetnz
Copy link
Member

Issue #11457

@emteknetnz emteknetnz mentioned this pull request Dec 16, 2024
Open
2 tasks
@emteknetnz emteknetnz force-pushed the pulls/5/form-validate branch from a6e26a5 to 9f82e40 Compare December 16, 2024 21:33
@emteknetnz emteknetnz marked this pull request as ready for review December 17, 2024 05:40
@emteknetnz emteknetnz force-pushed the pulls/5/form-validate branch from 9f82e40 to f51b4f7 Compare December 17, 2024 05:42
GuySartorelli
GuySartorelli approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are calls to validationResult() in other modules as well, which will need to be updated.

But this PR itself LGTM

@GuySartorelli GuySartorelli merged commit 307a6c5 into silverstripe:5 Dec 17, 2024
17 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/form-validate branch December 17, 2024 20:30
@GuySartorelli GuySartorelli mentioned this pull request Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli