Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH add nullable return types #11192

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

lekoala
Copy link
Contributor

@lekoala lekoala commented Apr 8, 2024

Description

More phpdoc updates

Don't merge yet, more updates are coming related to date fields

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@lekoala lekoala changed the title add nullable return types ENH add nullable return types Apr 8, 2024
@GuySartorelli
Copy link
Member

Setting to draft since it says not to merge it yet

@GuySartorelli GuySartorelli marked this pull request as draft April 8, 2024 22:23
@GuySartorelli GuySartorelli mentioned this pull request Apr 8, 2024
4 tasks
@GuySartorelli
Copy link
Member

As a general rule, please try to avoid creating a PR which isn't ready to merge yet. We're a lot more likely to notice a new PR (and start looking at it) than we are to notice updates to an existing PR.

@lekoala
Copy link
Contributor Author

lekoala commented Apr 26, 2024

@GuySartorelli didn't get the time to make the other changes i was planning to so this can be merged as is, i will reopen a new one when i find the time to make more improvements

@GuySartorelli GuySartorelli marked this pull request as ready for review April 28, 2024 21:02
@GuySartorelli GuySartorelli changed the base branch from 5.1 to 5.2 April 28, 2024 21:02
@GuySartorelli GuySartorelli merged commit 44f77ec into silverstripe:5.2 Apr 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants