Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve phpdoc types #11173

Closed
4 tasks done
lekoala opened this issue Mar 8, 2024 · 3 comments
Closed
4 tasks done

Improve phpdoc types #11173

lekoala opened this issue Mar 8, 2024 · 3 comments

Comments

@lekoala
Copy link
Contributor

lekoala commented Mar 8, 2024

Description

I'd like to make the codebase easier to use with phpstan

Additional context or points of discussion

See here for more details: #11149

Validations

  • You intend to implement the feature yourself
  • You have read the contributing guide
  • You strongly believe this feature should be in core, rather than being its own community module
  • You have checked for existing issues or pull requests related to this feature (and didn't find any)

PRs

@GuySartorelli
Copy link
Member

I've merged the linked PR.
@lekoala are there additional docblock types you want to update? Or should I close this issue as complete?

@lekoala
Copy link
Contributor Author

lekoala commented Mar 12, 2024

@GuySartorelli you can leave this open, i have a few others coming up but I'm rather in a rush at the moment so that could take a few weeks

@GuySartorelli
Copy link
Member

Since there haven't been any new PRs related to this in a while I'll close it.
@lekoala if you end up raising new PRs that are related to this feel free to @ me and I'll reopen it so we can track those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants