Use ::create instead of new in GridFieldDetailForm_ItemRequest #10789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates instances of `new X` to `X::create` so that Silverstripe classes will respect dependency injection
emteknetnz
requested changes
May 24, 2023
There was a problem hiding this comment.
Please rebase on 5.0 (as opposed to 5) after #10788 is merged and update target branch to 5.0 and we can immediately patch release 5.0.3 for you
|
I'll close this and rebase + change the branch name so it doesn't create issues with the composer jazz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates instances of
new XtoX::createso that Silverstripe classes will respect dependency injection