Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP Explicitly require psr/http-message ^1 #10788

Merged
merged 1 commit into from
May 24, 2023
Merged

DEP Explicitly require psr/http-message ^1 #10788

merged 1 commit into from
May 24, 2023

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request May 24, 2023
Closed
@emteknetnz emteknetnz force-pushed the pulls/4.13/http-message branch from 7657113 to b971395 Compare May 24, 2023 00:25
@emteknetnz emteknetnz changed the title DEP Explicitly require psr/http-message ^1.1 DEP Explicitly require psr/http-message ^1 May 24, 2023
@emteknetnz emteknetnz force-pushed the pulls/4.13/http-message branch from b971395 to e554516 Compare May 24, 2023 00:26
maxime-rainville
maxime-rainville requested changes May 24, 2023
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

If this is just occurring on a test class, should it be under the require-dev key instead of the require?

@emteknetnz
Copy link
Member Author

No, it needs to be in either require or be in conflict as >=2.0 (which would be kind of silly) - reason being that require-dev is ignored when installing from non-framework modules e.g. admin. That means it'll be doing basically nothing if it's in require-dev

@emteknetnz emteknetnz mentioned this pull request May 24, 2023
Closed
maxime-rainville
maxime-rainville approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit efd3ece into silverstripe:4.13 May 24, 2023
@maxime-rainville maxime-rainville deleted the pulls/4.13/http-message branch May 24, 2023 02:08
This was referenced May 30, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @maxime-rainville