BUG Update RelatedDataService to properly escape ClassName in Polymorphic relations #10713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI I ran that fix against a PostgreSQL and SQLite database and the matching test passed without issues. |
This was referenced Mar 1, 2023
|
The commit prefix should be |
|
FIX is the standard, though BUG also means it automatically shows in the changelog when it's generated via cow (our release tool), so I don't think we need to hold up merging this just for the prefix - https://github.com/silverstripe/cow/blob/master/src/Model/Changelog/ChangelogItem.php#L61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StandardRelatedDataServiceescapes ClassName in its query using some hackish logic instead of asking DB to do it for it.This breaks alternative DB adapters like SQLite.
Parent issue