Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS5: Make SQLite compatible #68

Closed
2 of 4 tasks
maxime-rainville opened this issue Feb 11, 2023 · 2 comments
Closed
2 of 4 tasks

CMS5: Make SQLite compatible #68

maxime-rainville opened this issue Feb 11, 2023 · 2 comments

Comments

@maxime-rainville
Copy link

maxime-rainville commented Feb 11, 2023

Acceptance criteria

  • CMS5 build is green
  • CMS5 build runs framework tests
  • Any removed API in the CMS5 branch is marked as deprecated in the CMS4 branch
  • Our CI is updated so you can install SQLite

PRs

@maxime-rainville
Copy link
Author

Just a couple extra notes here:

  • Our GitHub action CI does not currently support SQLite. Given that it's not something we actively want to support, I don't think it's worthwhile spending a lot of time getting it set up. I suggest spending 30 min to see if it's possible. If there's no obvious solution, I'm content with running the SQLite test locally and calling it a day.
  • Because SQLite is a database adapter, all of its test should be covered by the ORM tests in framework.
  • I recall some broken test in SQLite in CMS4. I don't think there were a big problem, so we ignored them. As long as it's mostly functional, I'm happy to merge the PR with some test failing.
  • From memory, to get the module working you need to define a SS_SQLITE_DATABASE_PATH variable and set SS_DATABASE_CLASS=SQLite3Database
  • The primary use case for this database adapter is to run tests. I don't thing there's anyone that actually use it to run tests.
  • I had a go at creating an action that allows you to pick whatever DB adapter you want a while a ago. This is the snippet I use to install SQLite. From what I'm reading there, it looks like it's built into the GitHub action image ... so you might not need to do any sorcery to get it working.

@sabina-talipova
Copy link

silverstripe/gha-ci#58 should be merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants