Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Convert slashes in paths when getting list of classes for file/folder #10687

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

xini
Copy link
Contributor

@xini xini commented Feb 13, 2023

see discussion #10686

src/Core/ClassInfo.php Outdated Show resolved Hide resolved
@xini xini requested a review from michalkleiner February 28, 2023 05:58
@michalkleiner michalkleiner changed the title fix path comparison on Windows FIX Convert slashes in paths when getting list of classes for file/folder Mar 1, 2023
…lder

This is to support the mechanism working on all operating systems where Windows may produce a mix of forward and backward slashes in some paths.
For working with the files it may not be a problem, but for exact string comparison the path delimiters need to be unified.
@michalkleiner michalkleiner force-pushed the fix-classinfo-paths-windows branch from 5fe75f0 to 6585d49 Compare March 1, 2023 07:32
@michalkleiner michalkleiner merged commit 94b24b2 into silverstripe:4.12 Mar 1, 2023
@xini
Copy link
Contributor Author

xini commented Mar 1, 2023

Thank you!

@xini xini deleted the fix-classinfo-paths-windows branch March 1, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants