add loading of automatic ORM field labels to i18nTextCollector #10686
Conversation
| $classes = ClassInfo::classes_for_file($filePath); | ||
| foreach ($classes as $class) { | ||
| // Skip non-implementing classes | ||
| if (!class_exists($class ?? '')) { |
There was a problem hiding this comment.
Is the null coalesce needed here?
There was a problem hiding this comment.
I don't know. I have copied the base of the method from https://github.com/silverstripe/silverstripe-framework/blob/4.12/src/i18n/TextCollection/i18nTextCollector.php#L818.
|
Since this is an enhancement I feel like this should target |
|
It's an enhancement for 4, but really it's just restoring the old 3.x functionality. Happy to rebase to 4 if you prefer? |
|
Adding functionality should be done in a minor release, even if that functionality was available in a previous major version of the module. Or in other words: yes please target |
|
done, see #10688 |
No description provided.