Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Remove PHPUnit 5.7 compatability hacks #10444

Merged

Conversation

GuySartorelli
Copy link
Member

Removes dual-class implementations from #10028
Removes dual-support functionality from #10150
Also remove unnecessary conflicts in composer.json

Parent issue

@sabina-talipova
Copy link
Contributor

@GuySartorelli , there are few small questions.
Should we use phpdocs and typehints together? Could you check, please, there are few places where you have both type docs.
And there is one failed CI, but it looks like failed staff aren't related to your changes.
If everything is Ok, I'll merge.

@GuySartorelli GuySartorelli force-pushed the pulls/5/remove-phpunit-57 branch from 29ed454 to 3284c06 Compare August 11, 2022 22:53
@GuySartorelli
Copy link
Member Author

The failing prefer-lowest test is also failing on the 5 branch - it's unrelated to this PR so you can disregard it.
I've updated the phpdocs.

@sabina-talipova sabina-talipova merged commit 7e695dd into silverstripe:5 Aug 15, 2022
@sabina-talipova sabina-talipova deleted the pulls/5/remove-phpunit-57 branch August 15, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants