-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Selectively register test folder in manifest #10150
API Selectively register test folder in manifest #10150
Conversation
4be5ef7
to
e993e6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still a work in progress, but most of the needed logic as been implemented ... it's just a question of updating Kernel and the Manifests to use it.
A question worth pondering is what we do with PHPUnit version 4, 6, 7, 8 or 10. Right now, I'm treating those as "unknown" ... this means those test will be included when running PHPUnit 5 and excluded when running PHPUnit 9. If we add support for PHPUnit 10 in a later release, we'll have to tweak this logic again.
A thing to note is that the new logic will only apply to tests folders that are at least 3 levels down (aka inside the vendor folder) ... if you write your tests using the PHPUnit 5 API and decide to install PHPUnnit 9, I'm not sure what we can do for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach looks great
I think the term 'CI Library' sounds, weird/wrong? Something along the lines of "Module test folder' is more correct?
9d6b33a
to
cbc4593
Compare
Ready for (hopefully) final review.
|
I've implemented @michalkleiner suggestions. |
Merge on green |
Parent issue