Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Entwine-based UploadField (use React-based one instead) #6481

Closed
chillu opened this issue Jan 11, 2017 · 3 comments
Closed

Remove Entwine-based UploadField (use React-based one instead) #6481

chillu opened this issue Jan 11, 2017 · 3 comments

Comments

@chillu
Copy link
Member

chillu commented Jan 11, 2017

We've created SilverStripe\AssetAdmin\Forms\UploadField with a design overhaul, making the field work in React sections. It currently sits in core alongside the entwine-based 'SilverStripe\Forms\UploadField`. Since we've made the new field useable in non-React sections, I don't see a good reason to keep both fields.

The entwine-based field has broken styling due to some button styling refactor, and uses a legacy HTMLEditor dialog. Since we're moving away from this legacy dialog for the "Insert Media" panel, the entwine-based UploadField would be the last user of this feature - and blocks removing it from core altogether.

  • Perform a feature by feature comparison with the old UploadField
  • Port over essential features
  • Document removed features in changelog
  • Set nice error messages on removed features (rather than "method not found")
@tractorcow
Copy link
Contributor

Also the insert-link modal, which allows you to attach a link to a file.

@chillu
Copy link
Member Author

chillu commented Feb 20, 2017

Chris to figure out how we deal with UploadField scaffolding and "insert media" with AssetUploadField being in the asset-admin module (not in framework)

@flamerohr flamerohr modified the milestones: CMS 4.0.0-beta1, CMS 4.0.0-alpha5 Feb 26, 2017
flamerohr pushed a commit to open-sausages/silverstripe-framework that referenced this issue Mar 1, 2017
@flamerohr flamerohr removed their assignment Mar 1, 2017
@tractorcow
Copy link
Contributor

See #6667

flamerohr pushed a commit to open-sausages/silverstripe-framework that referenced this issue Mar 2, 2017
flamerohr pushed a commit to open-sausages/silverstripe-framework that referenced this issue Mar 2, 2017
bergice pushed a commit to open-sausages/silverstripe-framework that referenced this issue Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants