-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Entwine-based UploadField (use React-based one instead) #6481
Milestone
Comments
This was referenced Jan 11, 2017
Also the insert-link modal, which allows you to attach a link to a file. |
Chris to figure out how we deal with UploadField scaffolding and "insert media" with AssetUploadField being in the asset-admin module (not in framework) |
flamerohr
pushed a commit
to open-sausages/silverstripe-framework
that referenced
this issue
Mar 1, 2017
See #6667 |
flamerohr
pushed a commit
to open-sausages/silverstripe-framework
that referenced
this issue
Mar 2, 2017
flamerohr
pushed a commit
to open-sausages/silverstripe-framework
that referenced
this issue
Mar 2, 2017
bergice
pushed a commit
to open-sausages/silverstripe-framework
that referenced
this issue
Nov 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We've created
SilverStripe\AssetAdmin\Forms\UploadField
with a design overhaul, making the field work in React sections. It currently sits in core alongside the entwine-based 'SilverStripe\Forms\UploadField`. Since we've made the new field useable in non-React sections, I don't see a good reason to keep both fields.The entwine-based field has broken styling due to some button styling refactor, and uses a legacy HTMLEditor dialog. Since we're moving away from this legacy dialog for the "Insert Media" panel, the entwine-based UploadField would be the last user of this feature - and blocks removing it from core altogether.
The text was updated successfully, but these errors were encountered: