Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG Default UploadField styling / edit form is broken #6476

Closed
2 tasks done
tractorcow opened this issue Jan 11, 2017 · 4 comments
Closed
2 tasks done

BUG Default UploadField styling / edit form is broken #6476

tractorcow opened this issue Jan 11, 2017 · 4 comments
Assignees
@tractorcow
Labels
affects/v4 type/bug
Milestone
CMS 4.0.0-alpha5

Comments

@tractorcow
Copy link
Contributor

tractorcow commented Jan 11, 2017 •
edited by flamerohr
Loading

Tasks

  • Create a FileHandleField interface, so that asset-admin can utilise DI.
  • Replace places where UploadField is used with the FileSelector interface in framework.

Background

Due to changes we have made to asset management and form styling, the UploadField (framework not asset-admin) has had both serious functionality regressions as well as styling deterioration.

image

image
@tractorcow tractorcow added this to the CMS 4.0.0-alpha5 milestone Jan 11, 2017
@kinglozzer kinglozzer mentioned this issue Jan 11, 2017
Closed
@chillu
Copy link
Member

chillu commented Jan 11, 2017

I propose we don't fix this, but rather remove the legacy UploadField in favour of the new React-powered one: #6481. What's the point of keeping old code around when we've written a replacement? Particularly since that'll lock us in to maintaining it until fricken 2020.

@tractorcow
Copy link
Contributor Author

Kill it!

@flamerohr
Copy link
Contributor

I've only replaced the UploadFields used in framework with these pull requests:
#6636
silverstripe/silverstripe-asset-admin#387

I've left the removing to the other very related issue.

@flamerohr flamerohr assigned flamerohr and unassigned flamerohr Feb 21, 2017
@tractorcow tractorcow self-assigned this Feb 22, 2017
@tractorcow
Copy link
Contributor Author

All merged.

@flamerohr flamerohr mentioned this issue Mar 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tractorcow tractorcow

Labels
affects/v4 type/bug
Projects
None yet
Milestone
CMS 4.0.0-alpha5
Development

No branches or pull requests
4 participants
@chillu @tractorcow @flamerohr @marcello-silverstripe